Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/views #6

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Feature/views #6

merged 3 commits into from
Nov 5, 2022

Conversation

topeogunleye
Copy link
Owner

Milestone 7: Views

  • Used preprocessed HTML file with embedded Ruby code.
  • Used layouts and templates for shared content.

Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @topeogunleye,

Good job !!!

To Highlight! 👏 🟢

✔️ Good commit messages
✔️ Clean and Organized code
✔️ Descriptive Readme file

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@topeogunleye topeogunleye merged commit fa80b30 into dev Nov 5, 2022
@topeogunleye topeogunleye mentioned this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants