Add setup mobile version #1
Conversation
There was a problem hiding this comment.
Hi @topeogunleye,
Great job so far!:clap: :clap:
To Highlight 🎊 🎊
- GitHub flow is followed. ✔️
- PR has a title and summary. ✔️
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.html
Outdated
| /> | ||
| <link rel="stylesheet" href="/css/style.css" /> | ||
| </head> |
There was a problem hiding this comment.
- The stylesheet is not connected to the HTML file properly and the image below is what shows when the page is loaded, Kindly fix this. Check the path being specified, since they are all in the same root directory, try using a
./to specify that .e.g./css/style.css
| me. | ||
| </p> | ||
|
|
||
| <section class="social"> |
There was a problem hiding this comment.
- The icons are not loaded to the HTML file properly as shown in the image in the previous comment, Kindly fix this. Check the path being specified, since they are all in the same root directory, try using a
./to specify that .e.g./images/svg/Twitter-icon.svg
| @@ -0,0 +1,100 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
- Use imperative tense and capitalizing for your commit messages going forward e.g. Add or Edit instead of Added or Edits
There was a problem hiding this comment.
Thank you. I have made all changed required
There was a problem hiding this comment.
Hi @topeogunleye ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
Added HTML markup for Toolbar and Headline Section
Added CSS Styling for the HTML Markup
Added Linters config files