Add mobile menu #22
Add mobile menu #22
Conversation
…rom mobile-container
There was a problem hiding this comment.
Hi Team 🙋♀️,
Good job so far! 👌
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️ 🚧
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- [OPTIONAL]
- Your navigation bar( logo and menu icon) should be fixed so, the user does not scroll back to the top every time
- Working on the hover style timing, it's a bit slow
- The menu list in mobile view has a blurred background. 💡 check for backdrop-filter
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.html
Outdated
| <li><a href="#contact">Contact</a></li> | ||
| </ul> | ||
| </div> | ||
| <button class="ham"></button> |
There was a problem hiding this comment.
- Please use the color given in the template for this icon
There was a problem hiding this comment.
Hi @topeogunleye,
Nice Work 👏
Congratulations! 🎉 Project Approved ✅
Your project is complete! There is nothing else to say other than... it's time to merge it 🚀
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Added Changes