Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests #155

Closed
wants to merge 29 commits into from
Closed

Updating tests #155

wants to merge 29 commits into from

Conversation

zachmayer
Copy link
Collaborator

No description provided.

There’s no longer S3 methods for trimming those models, the trimming
code lives in the model objects.
Currently no trim method for earth models
Trying to skip vignette building in tests
travis supports R natively now!
for createTimeSlices
see what happens if we take out some latex packages
Added non-CRAN tests packages to travis install
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling c1f14eb on tests into 8233d15 on master.

@zachmayer
Copy link
Collaborator Author

Ok, so the new tests for model trimming are what's failing here. The weird thing is, they run fine locally, and R CMD CHECK passes. Are there any special packages I may need to install to run the trim tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling 4a00ae8 on tests into 8233d15 on master.

@zachmayer
Copy link
Collaborator Author

The error I'm getting is really weird:

* checking tests ...
  Runningtestthat.R’ [12s/12s]
 ERROR
Running the tests intests/testthat.Rfailed.
Last 13 lines of output:
         trim = TRUE))
  6: train(x, y, weights = w, ...)
  7: train.default(x, y, weights = w, ...)
  8: checkInstall(models$library)
  9: stop()

  testthat results ================================================================
  OK: 89 SKIPPED: 0 FAILED: 2
  1. Error: bayesglm classification 
  2. Error: bayesglm regression 

  Error: testthat unit tests failed
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ininst/doc... OK
* checking running R code from vignettes ...caret.Rnw... OK
 OK
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* DONE
Status: 1 ERROR, 1 WARNING, 1 NOTE
See/home/travis/build/topepo/caret/pkg/caret/caret.Rcheck/00check.logfor details.

@zachmayer
Copy link
Collaborator Author

I might have figured it out— explicitly loading the package seems to work

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling 8369f59 on tests into 8233d15 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling 52fce53 on tests into 8233d15 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling c652729 on tests into 8233d15 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling c652729 on tests into 8233d15 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.65%) to 13.88% when pulling c652729 on tests into 8233d15 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.65%) to 13.88% when pulling 675215a on tests into 8233d15 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.65%) to 13.88% when pulling 675215a on tests into 8233d15 on master.

@topepo
Copy link
Owner

topepo commented May 27, 2015

Should I merge this in?

@zachmayer
Copy link
Collaborator Author

@topepo Let me squash it down to a single commit.

Are you ok with adding more packages to the "suggests" field? That's the only way I could get the trim tests to work.

@topepo
Copy link
Owner

topepo commented May 27, 2015

On Tue, May 26, 2015 at 9:26 PM, Zach Mayer notifications@github.com
wrote:

@topepo https://github.com/topepo Let me squash it down to a single
commit.

Sounds good.

Are you ok with adding more packages to the "suggests" field? That's the
only way I could get the trim tests to work.

I'd like to avoid it if at all possible. Which ones?

@zachmayer
Copy link
Collaborator Author

kknn
arm
glmnet
rpart
C50,
ipred
plyr
earth

I'll figure out how to install them on travis manually (it should be easy, but it's not!)

 and try really hard to install them
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) to 10.94% when pulling 598a68f on tests into 8233d15 on master.

@zachmayer zachmayer closed this Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants