Fix incorrect sampling in bagged avNNet. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avNNet with bag = TRUE currently samples without replacement. This therefore just reorders the rows. avNNet now samples WITH replacement therefore giving proper bagging.
topepo
added a commit
that referenced
this pull request
May 25, 2015
Fix incorrect sampling in bagged avNNet.
|
Thanks. That is definitely a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avNNet with bag = TRUE currently samples without replacement. This therefore just reorders the rows.
avNNet now samples WITH replacement therefore giving proper bagging.
I don't think the same error occurs in other models but I'm not sure.