Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for retrieveClanHandler options #49

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Adding tests for retrieveClanHandler options #49

merged 2 commits into from
Aug 26, 2019

Conversation

matheuscscp
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 24, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 62.06% when pulling 51af63e on matheuscscp:tests/retrieveclan-options-tests into 5c73709 on topfreegames:master.

yuriabrito
yuriabrito reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@yuriabrito yuriabrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm out of the loop a bit for this feature. Looks like you've added great amount of cov for the new feature. Nice job!

Makefile Outdated Show resolved Hide resolved
api/clan_test.go Show resolved Hide resolved
@yuriabrito
Copy link
Contributor

LGTM

@matheuscscp matheuscscp merged commit 28f1564 into topfreegames:master Aug 26, 2019
@matheuscscp matheuscscp deleted the tests/retrieveclan-options-tests branch August 26, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriabrito yuriabrito yuriabrito approved these changes

@cscatolini cscatolini Awaiting requested review from cscatolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheuscscp @coveralls @yuriabrito