Add docker-compose to run Khan locally #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2020 00:59
strings.ReplaceAll was removed from go 1.11 and it's making the CI pipeline to break
danielbdias
reviewed
Nov 18, 2020
docker-compose.yml
Outdated
| retries: 3 | ||
|
|
||
| networks: | ||
| khan: |
There was a problem hiding this comment.
A suggestion: we could use the same network name for all services, to help us to integrate with other services (this is why I named the network as wildlife-services in other services).
docker-compose.yml
Outdated
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| command: "make migrate" |
There was a problem hiding this comment.
Using this configuration with a docker-compose up without reading README, migrate and khan will be running concurrently. Could we have problems with the khan container due to this?
Which is the advantage of running migrate outside the khan container?
There was a problem hiding this comment.
Good point. I can override the command to execute both make commands instead of using two separated services.
|
Closed, done at #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the necessary infrastructure for one to try the project in their local environment.