Add docker-compose for khan #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
approved these changes
Mar 31, 2021
danielbdias
reviewed
Apr 1, 2021
| @@ -1,19 +1,20 @@ | |||
| FROM golang:1.15.2-alpine | |||
|
|
|||
| MAINTAINER TFG Co <backend@tfgco.com> | |||
| LABEL TFG Co <backend@tfgco.com> | |||
| WORKDIR /go/src/github.com/topfreegames/khan | |||
|
|
|||
| EXPOSE 80 | |||
|
|
|||
| RUN apk update | |||
There was a problem hiding this comment.
A suggestion here: it's good to chain multiple installation commands in the same RUN to avoid caching issues. (reference)
Here, we can chain 3 RUN commands:
RUN apk update && \
apk add git make g++ apache2-utils curl && \
apk add --update bash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally created by @mathnogueira at #61.
Since this feature is very interesting, I created this PR from a fresh master and made a few tweaks