Always set status to RollingUpdate if operation exists #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to do operation that requires to recreate the pods (change image, env vars, etc ...) and there are no pods the operation gets stuck until it timeouts. This happens because on
GetOperationStatus
it checks if the operation is inRollingUpdate
status and if not the progress always returns zero andEnsureCorrectRooms
do not set the status if the number of invalid pods is zero.This PR makes
EnsureCorrectRooms
always set the status toRollingUpdate
if there is a current operation even if there are zero pods to update.