Fix memory leak when using http auth #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flapezoti
approved these changes
May 27, 2021
felipejfc
reviewed
May 27, 2021
| _, _ = io.Copy(ioutil.Discard, response.Body) | ||
| _ = response.Body.Close() | ||
| } | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
I would put the error check before, so that you wouldn't need to check if response or the body are nil
There was a problem hiding this comment.
I agree, but the problem is when the error is related to Redirection; err will be not nil and resp.Body will also be non-nil, so it would still leak memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.