Reduce connection close error logs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1073
💛 - Coveralls |
rodopoulos
approved these changes
Dec 10, 2020
|
😍 this fixes #138 right? |
Yes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection closes without any message left, there is always a log that appears. This happens not even when the connection is established and closed, but in all connections being closed. This has shown to be a very annoying log (sometimes entire slots of logs are just composed by this message) and does not fully represent the error and can be misleading.
{"component":"pitaya","level":"error","msg":"Error reading next available message: invalid header","time":"2020-12-09T21:21:25Z"}The idea here is to treat a connection close differently from, for example, a header with an invalid format or an incomplete message. By doing this, we are able to not log an error when it happens and reduce the noise generated in the logs.