Apply master (v1) latest version to v2 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve metrics documentation
When agent write goroutine closed the channel heartbeat and send functions could still write to the channel causing a panic. send already had a recover for this but heartbeat didn't have. This commit does not close the channel anymore and to make so the writers don't block sending when an agent is closed a select is used reading from die channel that signals that a agent is closed. The write channel is never closed but it's ok as when a Agent is not used anymore it will be garbage collected as the agent is the only reference to it.
Fix agent race condition
…lose-logs Reduce connection close error logs
* Add more information to nats timeout error logs
processRemote function is always called with a nil server and because of this pitaya was crashing in production. This commit moves the log from this process to rpc call function that has the target information and returns this info wrapping the error returned.
DylanGuedes
reviewed
Jan 5, 2021
| @@ -68,6 +69,12 @@ func (m *MyComp) RemoteErr(ctx context.Context) (*test.SomeStruct, error) { | |||
|
|
|||
| type unregisteredStruct struct{} | |||
|
|
|||
| func errorIs(t *testing.T, err1 error, err2 error) { | |||
| if !assert.ObjectsAreEqual(err1, err2) && !errors.Is(err1, err2) { | |||
There was a problem hiding this comment.
Shouldn't it be !assert.ObjectsAreEqual(err1, err2) || !errors.Is(err1, err2)?
There was a problem hiding this comment.
I think we assume that the struct being equal is not enough to consider it as the same (same for the opposite). But @victor-carvalho has more context on it.
There was a problem hiding this comment.
Gotcha. Just double checking, anyway 😂
Pull Request Test Coverage Report for Build 1092
💛 - Coveralls |
|
LGTM |
victor-carvalho
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is being ported: #139, #143, #148, #151, #150 and #154.
The latest addition to master (#153) is not being ported in this PR. It will require some changes and will be done in a separate PR.