Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stale ETCD routines when ETCD server is unavailable #337

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Fix stale ETCD routines when ETCD server is unavailable #337

merged 3 commits into from
Sep 6, 2023

Conversation

rsafonseca
Copy link
Collaborator

  • Ensures DialTimeout is respected (this has been broken since it became async on etcd client 3.3.x)
  • Sets a deadline on Lease Grant call to ensure it doesn't block forever
  • Adds error logs when nats client detects a slow consumer
  • Reduces the noise of logs regarding failure to read messages when the remote client has already closed the connection

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6011313967

  • 4 of 18 (22.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 61.786%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/handler.go 4 6 66.67%
cluster/etcd_service_discovery.go 0 4 0.0%
cluster/nats_rpc_common.go 0 8 0.0%
Totals Coverage Status
Change from base Build 5978925362: -0.09%
Covered Lines: 4789
Relevant Lines: 7751
💛 - Coveralls

felipejfc
felipejfc requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@felipejfc felipejfc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets create a new option for the timeout and we're good to go

cluster/etcd_service_discovery.go Outdated Show resolved Hide resolved
vitorbaraujo
vitorbaraujo reviewed Aug 29, 2023
View reviewed changes
service/handler.go Show resolved Hide resolved
cluster/nats_rpc_common.go Outdated Show resolved Hide resolved
@rsafonseca rsafonseca merged commit 931c707 into main Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorbaraujo vitorbaraujo vitorbaraujo left review comments

@felipejfc felipejfc felipejfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsafonseca @coveralls @felipejfc @vitorbaraujo