Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] Pipeline now receives the decoded arguments insted of raw data #41

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

rcmgleite
Copy link
Contributor

@rcmgleite rcmgleite commented Aug 16, 2018

This PR changes the signature of the pipeline handler.

The ideia is to make possible for pipelines to access the decoded struct from the message bytes.

Motivation

Make it possible to, for example, create pipelines for struct field validation (see the example added to /examples/demo/pipeline)

TODOs

  • Fix examples that used pipelines with the old signature

Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok but I'm not sure it will work as intended if you need to convert (actually type assert) interface{} to CreatePlayerCheatArgs or CreatePlayerCheatResponse.

Please add an example with a BeforeFilter using the values received in the CreatePlayerCheatArgs and AfterFilter changing the response.

@coveralls
Copy link

coveralls commented Aug 16, 2018

Pull Request Test Coverage Report for Build 416

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 75.416%

Files with Coverage Reduction New Missed Lines %
agent/agent.go 10 77.57%
Totals Coverage Status
Change from base Build 410: -0.1%
Covered Lines: 3718
Relevant Lines: 4930

💛 - Coveralls

@rcmgleite
Copy link
Contributor Author

@cscatolini done!

@cscatolini
Copy link
Contributor

Great! Thanks! Is this still WIP? Can we merge this?

@rcmgleite rcmgleite changed the title [WIP] Pipeline now receives the decoded arguments insted of raw data [Done] Pipeline now receives the decoded arguments insted of raw data Aug 16, 2018
@rcmgleite
Copy link
Contributor Author

rcmgleite commented Aug 16, 2018

It's done!

@cscatolini cscatolini merged commit 7465ba3 into master Aug 16, 2018
@cscatolini cscatolini deleted the refactor/pipeline branch September 12, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants