add hide_labels to stacked bar graphs #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
commented
Sep 13, 2020
| end | ||
|
|
||
| def hide_bottom_label_area? | ||
| hide_labels? |
There was a problem hiding this comment.
Bar was updated to match the changes in base.
|
@Watson1978 Ready for review. Includes changes to base that facilitate extending this to side graphs. |
elrayle
commented
Sep 13, 2020
| def hide_bottom_label_area? | ||
| @hide_line_markers | ||
| end | ||
|
|
There was a problem hiding this comment.
The changes in base set the stage for side bar graphs.
elrayle
commented
Sep 13, 2020
| @datasets = [ | ||
| [:Jimmy, [25, 36, 86, 39]], | ||
| [:Charles, [80, 54, 67, 54]], | ||
| [:Julie, [2, 29, 35, 38]] |
There was a problem hiding this comment.
I don't know that having Julie start with 2 instead of 22 was intentional. This could be updated to use the default data like the other tests. The test passes with this data.
elrayle
commented
Sep 14, 2020
| [:Charles, [80, 54, 67, 54]], | ||
| [:Julie, [2, 29, 35, 38]] | ||
| ] | ||
| g = setup_basic_graph |
There was a problem hiding this comment.
Refactored the tests to use the setup_basic_graph pattern seen in other test sets.
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.