add hide_labels to stacked side bar graphs #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
hide_labels_stacked_side_bar
branch
from
6977449
to
4387bc3
Compare
elrayle
commented
Sep 14, 2020
| @@ -76,6 +76,14 @@ def hide_labels? | |||
| @hide_labels | |||
| end | |||
|
|
|||
| def hide_left_label_area? | |||
There was a problem hiding this comment.
Changes in bar.rb are the same ones made in PR #450, which should make the PRs compatible for merging.
elrayle
commented
Sep 14, 2020
| @@ -504,6 +504,14 @@ def hide_labels? | |||
| @hide_line_markers | |||
| end | |||
|
|
|||
| def hide_left_label_area? | |||
There was a problem hiding this comment.
Changes in base.rb are the same ones made in PR #450, which should make the PRs compatible for merging.
elrayle
commented
Sep 14, 2020
| } | ||
| end | ||
|
|
||
| def test_bar_graph | ||
| g = Gruff::SideStackedBar.new | ||
| g = setup_basic_graph |
There was a problem hiding this comment.
Refactored tests to use the setup_basic_graph pattern.
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.