Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package? #897

Open
Kreeblah opened this issue Sep 1, 2024 · 6 comments
Open

Debian package? #897

Kreeblah opened this issue Sep 1, 2024 · 6 comments
Labels
C-feature request New feature request

Comments

@Kreeblah
Copy link
Contributor

Kreeblah commented Sep 1, 2024

I want to suggest some general feature

It would be nice if there were a Debian package available for this (even if it requires adding another repo). Currently, Debian stable doesn't have a new enough version of rust in its packaging system to build the project (and, given their focus is on stability rather than the newest versions of things, I wouldn't expect that to change), so installing it requires installing binaries the package manager doesn't know about. Even installing cargo-binstall doesn't work, as it requires a newer version of rustc than Debian offers.

It'd be much easier if there were a package that could just install the binary on its own, rather than having to build it on a host and then copy it over to other hosts every time there's an update.

@Kreeblah Kreeblah added the C-feature request New feature request label Sep 1, 2024
@SteveLauC
Copy link
Member

Currently, Debian stable doesn't have a new enough version of rust in its packaging system to build the project

What errors did you get when you tried to build Topgrade with that version of Rust toolchain?🤔

It would be nice if there were a Debian package available for this

Packaging for Linux is hard, so I won't do this. But I am willing to help if someone wants to get this done.

@SteveLauC SteveLauC added the wontfix This will not be worked on label Sep 2, 2024
@Kreeblah
Copy link
Contributor Author

Kreeblah commented Sep 2, 2024

Currently, Debian stable doesn't have a new enough version of rust in its packaging system to build the project

What errors did you get when you tried to build Topgrade with that version of Rust toolchain?🤔

It fails on one of the dependencies, because the provided version of rustc is 1.63.0.

error: failed to compile `topgrade v15.0.0`, intermediate artifacts can be found at `/tmp/cargo-install7Fo7de`

Caused by:
  package `roff v0.2.2` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.63.0
  Try re-running cargo install with `--locked`

It would be nice if there were a Debian package available for this

Packaging for Linux is hard, so I won't do this. But I am willing to help if someone wants to get this done.

I might take a look at this when I have time, then. I've never built a Debian package before, but I've built packages for other OSes (like FreeBSD), so I imagine I'll be able to figure it out somehow and get something set up as a GitHub action.

@SteveLauC
Copy link
Member

It fails on one of the dependencies, because the provided version of rustc is 1.63.0.

Looks like Topgrade's MSRV is 1.70.

I might take a look at this when I have time,

Appreciate it, feel free to ask me for help if needed!

@SteveLauC
Copy link
Member

#898 adds the .deb files to the release assets, though we are currently not adding them to the official Debian repos, 2 issues remain to be solved:

  1. Topgrade needs Rust toolchain 1.70 or higher, the Rust toolchain packaged by Debian is 1.63.0, we don't know if Debian will accept tools that can't be built with available Debian packages.
  2. Debian packages need a changelog, Topgrade does not have changelogs.

For more information, see the discussion there.

@SteveLauC
Copy link
Member

Looks like Topgrade's MSRV is 1.70.

This is incorrect, Topgrade needs Rust 1.76.0 or higher, I just pinned the toolchain to the MSRV in #900.

@Kreeblah
Copy link
Contributor Author

Kreeblah commented Sep 4, 2024

Ah, nice. That'll help identify when it need to be updated in the documentation.

@SteveLauC SteveLauC removed the wontfix This will not be worked on label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants