Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

fix: Remove leading space in interactive element regex #116

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix: Remove leading space in interactive element regex #116

merged 1 commit into from
Sep 11, 2019

Conversation

BisuGit
Copy link
Collaborator

@BisuGit BisuGit commented Sep 11, 2019

Description

DevQA

DevQA Prep

  • Run pod install
  • Test RichTextView to ensure that it passes (unit and UI tests)
  • Navigate to the Example project in the root Example folder and run the app
  • Ensure that everything in the Example app looks visually correct

DevQA Steps

  • Navigate to example project VC and change the private enums to InputOutputModuleView(text: """ [interactive-element id=1]Some interactive element text[/interactive-element] different text[interactive-element id=1]more interactive element text[/interactive-element] """)

Comments

@BisuGit BisuGit added the reviewme Indicates a PR that needs to be reviewed label Sep 11, 2019
@aelkady aelkady changed the title Update RichTextParser.swift fix: Remove leading space in interactive element regex Sep 11, 2019
@aelkady aelkady merged commit 700e5f4 into master Sep 11, 2019
@aelkady aelkady deleted the remove-spaces-from-interactive-element-ragex-multiline-string branch September 11, 2019 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aelkady aelkady aelkady approved these changes

Assignees

@aelkady aelkady

Labels
reviewme Indicates a PR that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BisuGit @aelkady