Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snapshot diffing support #526

Merged
merged 3 commits into from
May 11, 2022
Merged

feat: add snapshot diffing support #526

merged 3 commits into from
May 11, 2022

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jun 17, 2021

Description

Adds snapshot naming and diffing support to promote committing short focused snapshot assertions.

Related Issues

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

Review the diff representation

@iamogbz iamogbz marked this pull request as draft June 17, 2021 01:02
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #526 (54a0a06) into master (3f32f4b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   99.01%   99.03%   +0.01%     
==========================================
  Files          20       20              
  Lines        1223     1244      +21     
==========================================
+ Hits         1211     1232      +21     
  Misses         12       12              

@iamogbz iamogbz linked an issue Jun 17, 2021 that may be closed by this pull request
Base automatically changed from format-ambr-py-like to next October 31, 2021 01:07
@iamogbz iamogbz changed the base branch from next to master October 31, 2021 01:17
@iamogbz iamogbz force-pushed the feat-snapshot-diff branch 3 times, most recently from 58e2054 to 1440e9a Compare May 10, 2022 22:50
@iamogbz iamogbz marked this pull request as ready for review May 10, 2022 22:58
@iamogbz iamogbz requested a review from noahnu May 10, 2022 22:58
@noahnu
Copy link
Collaborator

noahnu commented May 10, 2022

Can you update the README docs for this feature?

@noahnu noahnu merged commit e424f31 into master May 11, 2022
@noahnu noahnu deleted the feat-snapshot-diff branch May 11, 2022 00:42
tophat-opensource-bot pushed a commit that referenced this pull request May 11, 2022
# [2.1.0](v2.0.0...v2.1.0) (2022-05-11)

### Features

* add snapshot diffing support ([#526](#526)) ([e424f31](e424f31))
@tophat-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot diffing in test assertion
3 participants