generated from tophat/new-project-kit
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: diffing excessively large snapshot lines #778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamogbz
commented
Jul 20, 2023
Comment on lines
-49
to
+50
def test_diff_large_lines(self, Reporter, osenv): | ||
n_count = 5000 | ||
def test_diff_large_lines(self, Reporter, snapshot, osenv): | ||
n_count = 1000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5000
was not large enough apparently
iamogbz
commented
Jul 20, 2023
assert snapshot_utf8 == "apple" | ||
assert snapshot_utf8 == content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
noahnu
approved these changes
Jul 20, 2023
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
## [4.0.8](v4.0.7...v4.0.8) (2023-07-20) ### Bug Fixes * diffing excessively large snapshot lines ([#778](#778)) ([64b4265](64b4265))
🎉 This PR is included in version 4.0.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit the amount of characters used when comparing line diffs.
Can be validated by changing
DIFF_LINE_WIDTH_LIMIT
to a value like1000000
and runninginv test -t test_diff_large_lines
test_unicode
Related Issues
Checklist
Additional Comments
Follow up to #776