Skip to content

Commit

Permalink
feat!: Use lvmdEmebbed by default
Browse files Browse the repository at this point in the history
BREAKING CHANGE:  Using lvmdEmbedded by default reduces pod count per host by 1 and causes no loss of functionality. Users are only impacted if they have added initicontainers or modified volumes/mounts.

Signed-off-by: Ryan Faircloth <ryan@dss-i.com>
  • Loading branch information
ryanfaircloth committed Jan 17, 2024
1 parent 1710d69 commit 355669e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/topolvm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ scheduler:
# lvmd service
lvmd:
# lvmd.managed -- If true, set up lvmd service with DaemonSet.
managed: true
managed: false

# lvmd.socketName -- Specify socketName.
socketName: /run/topolvm/lvmd.sock
Expand Down Expand Up @@ -215,7 +215,7 @@ lvmd:
node:
# node.lvmdEmbedded -- Specify whether to embed lvmd in the node container.
# Should not be used in conjunction with lvmd.managed otherwise lvmd will be started twice.
lvmdEmbedded: false
lvmdEmbedded: true
# node.lvmdSocket -- Specify the socket to be used for communication with lvmd.
lvmdSocket: /run/topolvm/lvmd.sock
# node.kubeletWorkDirectory -- Specify the work directory of Kubelet on the host.
Expand Down

0 comments on commit 355669e

Please sign in to comment.