Guard against assets not being configured #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clupprich
force-pushed
the
fix-rails5-api
branch
from
7d21f90
to
078d80a
Compare
|
Why don't check |
|
I tried that, but that's hidden behind some method_missing magic. |
|
Also tried the usual suspects like #key?, and checked the documentation, but seems that you can't query if a config entry exists. We could try a respond_to, however. |
clupprich
force-pushed
the
fix-rails5-api
branch
from
078d80a
to
9f71236
Compare
|
@pyromaniac I've changed the code now to check if the |
That happens when Rails (5) is run in API mode
clupprich
force-pushed
the
fix-rails5-api
branch
from
9f71236
to
801bc04
Compare
|
Perfect, thanks! |
pyromaniac
added a commit
that referenced
this pull request
Dec 29, 2015
Guard against assets not being configured
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #277 unfortunately breaks Rails applications in API mode (Rails 5 or via the
rails-apigem): When configuring an application API only, theRails.application.config.assetsentry isn't available and theRequestStrategymiddleware crashes the application. This now checks if the application is running on api-only mode and does the test for the assets-path afterwards.