Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS registering FormsMap.PropertyChanged several times #60

Closed
CliffCawley opened this issue Apr 5, 2016 · 1 comment
Closed

iOS registering FormsMap.PropertyChanged several times #60

CliffCawley opened this issue Apr 5, 2016 · 1 comment
Labels

Comments

@CliffCawley
Copy link
Contributor

This only happens on iOS as on Android you're doing the FormsMap.PropertyChanged event registration call in OnElementChanged.

On iOS however it seems the MapLoaded can be called multiple times. For me it can get called 2-3 times without any calls to OnElementChanged. Once when the map is first initialized and again when it's finished animating to it's destination MapCenter

            this.FormsMap.PropertyChanged += OnMapPropertyChanged;

As a test I unregistered right before

            this.FormsMap.PropertyChanged -= OnMapPropertyChanged;
            this.FormsMap.PropertyChanged += OnMapPropertyChanged;

and I no longer get multiple PropertyChanged notifications

@TorbenK
Copy link
Owner

TorbenK commented Apr 6, 2016

Same root as #61

TorbenK added a commit that referenced this issue Apr 29, 2016
      New: TKCustomMapPin is BindableObject
      New: All Commands also available as Event
      New: Possibility to set the anchor position of a pin(Alpha)

      Fixed: Issue with PinTinColor(iOS) #68
      Fixed: Issue with multiple calls to MapLoaded(iOS) #60,#61,#50
      Fixed: Issue with missing culture information when converting coordinates to string(Android) #55
      Fixed: Double tap no longer triggers MapClicked(iOS) #46
      Fixed: Bounds calculation after route calculation is now correct
      Fixed: Collection events getting unregistered properly
      Fixed: Issue when route gets removed from collection during calculation

      Minor bugfixes
@TorbenK TorbenK closed this as completed Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants