Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No MultiLabelMarginCriterion #152

Open
korkinof opened this issue Oct 14, 2015 · 6 comments
Open

No MultiLabelMarginCriterion #152

korkinof opened this issue Oct 14, 2015 · 6 comments

Comments

@korkinof
Copy link

Hi guys,
I noticed there is no cunn implementation of this criterion.
Do you plan to implement that any time soon?
We could try implementing it ourselves otherwise or just keep the criterion on CPU.
Best,
D.

@clementfarabet
Copy link
Member

Had written this code a long time ago, just made a PR for it now:
#153

I don't have a good unit test for it though. If someone can write a quick one that would be great.

@JirenJin
Copy link

@clementfarabet Hi, I really want to use the MultiLabelMarginCriterion on GPU. I have found your fork of cunn, however, I do not know how to use it. I mean I only know installing packages using luarocks install... Could you please tell me how to use your code?

@soumith
Copy link
Member

soumith commented Oct 22, 2015

hey Jireh,

You can do:

git clone https://github.com/clementfarabet/cunn -b master
cd cunn
luarocks make rocks/cunn-scm-1.rockspec

Then you will get his version of cunn that has GPU MultiLabelMarginCriterion

@JirenJin
Copy link

@soumith Thank you for your reply. However, I just tried exactly the same command you suggested, but failed with this error:

make[1]: *** [CMakeFiles/cunn.dir/all] Error 2
make: *** [all] Error 2

Do you know the possible reasons?
Yesterday I have installed iTorch using the similar way, and succeeded.

@Parry26
Copy link

Parry26 commented Jan 14, 2016

I have just tried this and got the same errors above. Please advise.

@zhangguoxiao
Copy link

@soumith I have tried your advice and got the same errors above.any advise?or where can I find the right MultiLabelMarginCriterion.cu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants