-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normal exit is not clean #16
Comments
@mavenlin it is interesting, and it is a bug in the trepl interpreter (not a bug in luajit). For example, if you run the script with: What's the use-case where you ran into this bug? It is likely something minor and not concerning to anything practically relevant. |
@soumith In my case I wrapped the parameter server as userdata, gc calls the destructor in C++ side, which notifies the server side of the exit. If it is not gced the server is never notified. |
fixed the issue via torch/trepl#38 Thanks a lot for the report. |
A bug in luajit.
When executing the following,
at exit 'gc' will not be printed, however when the last two lines of code are uncommented it will print 'gc'.
Which means at exit collectgarbage is not called by the interpreter.
It is a problem when gc writes log to files, or gc disconnects from a server.
@soumith What's your opinion on this?
The text was updated successfully, but these errors were encountered: