Several *Table modules lack type() method

[mys007]

Several *Table modules (e.g. JoinTable or CAddTable) store tables in their gradInput member variable but define no appropriate type(type) method. This leads to the issue that a model cannot change type (e.g. float<->cuda) once a backpropagation has been performed. The proposed fix is to define the method appropriately, e.g.

function CAddTable:type(type)
   parent.type(self, type)
   self.gradInput = {}
end

[nicholas-leonard]

They inherit it from Module:
https://github.com/torch/nn/blob/master/Module.lua#L130
which uses recursiveType:
https://github.com/torch/nn/blob/master/Module.lua#L116

So this shouldn't be an issue?

[mys007]

Oh, of course, that should work. My apology, I was on the getParamsByDevice branch, which is missing this functionality.

[soumith]

I'll rebase that branch to master tomorrow, sorry about that @mys007