Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpatialConvolutionMM doesn't pass unit tests #237

Closed
fmassa opened this issue Apr 21, 2015 · 7 comments
Closed

SpatialConvolutionMM doesn't pass unit tests #237

fmassa opened this issue Apr 21, 2015 · 7 comments

Comments

@fmassa
Copy link
Contributor

fmassa commented Apr 21, 2015

Since commit c0c79f1, nn.test() segfaults at SpatialConvolutionMM.

@andresy
Copy link
Member

andresy commented Apr 21, 2015

it is certainly because you did not update torch7 core

@fmassa
Copy link
Contributor Author

fmassa commented Apr 21, 2015

Precisely, I was using the current torch installation from distro, which doesn't contain the newest commits from torch7. Sorry about the false alarm.

@fmassa fmassa closed this as completed Apr 21, 2015
@andresy
Copy link
Member

andresy commented Apr 21, 2015

arg, maybe @soumith could update it when he finds some time (in his already overbooked schedule)?

@fmassa
Copy link
Contributor Author

fmassa commented Apr 21, 2015

It's actually my fault, I only updated the nn repo on top of distro installation.

@soumith
Copy link
Member

soumith commented Apr 21, 2015

hmm, torch/distro does have the atomic commits now. I updated 3 days ago.

@fmassa
Copy link
Contributor Author

fmassa commented Apr 21, 2015

But you didn't update the torch package
torch/distro@bdce3fc

@soumith
Copy link
Member

soumith commented Apr 21, 2015

good catch, updating. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants