Don't reopen image files that are hosted externally #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing the following with an external image backend: - Uploading through image chooser (fails) - Visiting the edit page of an image with a null file_size (fails) - Editing an image, changing the image file - Adding a new image The latter two do not fail, I thought I'd add them to reduce risk of regressions in the future
| if self.is_stored_locally(): | ||
| self.file.open('rb') | ||
| else: | ||
| # Some external storage backends don't allow reopening |
There was a problem hiding this comment.
Perhaps it might be simpler to just get a fresh File object for local files as well
|
I was seeing this when using my FTP based remote storage, as well. I was mainly testing using the single image uploader. I noticed that the renditions in the list view were generated fine, but it crashed when trying to generate the renditions for the detail view. If I get the chance, I can try playing with it in my dev environment. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1397
This caused crashes on the chooser upload and image edit views.
Some image hosting backends don't allow files to be reopened once closed and will crash with
ValueError("The file cannot be reopened.")if you tried it.I've seen this issue in the following third-party storage backends:
offsite_storage.storages.S3MediaStoragestorages.backends.s3.S3Storagestorages.backends.apache_libcloud.LibCloudStorageThis PR modifies the
Image.get_willow_imagemethod to make it get a freshFileinstance if it detects that it is reopening a file that is externally hosted. It also adds some utils to allow us to test against a dummy external storage backend.