Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin html5lib to 0.999999 #2842

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Conversation

LiamBrenner
Copy link
Contributor

@LiamBrenner LiamBrenner commented Jul 15, 2016

Temporary fix for issue in html5lib update causing beautifulsoup4 (bs4) to raise an error, meaning wagtail tests fail in master, 1.5.x and 1.4.x, haven't tested before that yet.

A new version of html5lib was released, 0.99999999, and this release seems to be causing an error. The error seems to be being raised within beautifulsoup4 (bs4). It seems a bug report or fix for it is yet to be logged/pushed for bs4.

  File "/vagrant/repos/wagtail/wagtail/tests/testapp/models.py", line 22, in <module>
    from wagtail.wagtailcore.blocks import CharBlock, RichTextBlock
  File "/vagrant/repos/wagtail/wagtail/wagtailcore/blocks/__init__.py", line 5, in <module>
    from .field_block import *  # NOQA
  File "/vagrant/repos/wagtail/wagtail/wagtailcore/blocks/field_block.py", line 15, in <module>
    from wagtail.wagtailcore.rich_text import RichText
  File "/vagrant/repos/wagtail/wagtail/wagtailcore/rich_text.py", line 11, in <module>
    from wagtail.wagtailcore.whitelist import Whitelister
  File "/vagrant/repos/wagtail/wagtail/wagtailcore/whitelist.py", line 9, in <module>
    from bs4 import BeautifulSoup, Comment, NavigableString, Tag
  File "/home/vagrant/venv/lib/python3.4/site-packages/bs4/__init__.py", line 30, in <module>
    from .builder import builder_registry, ParserRejectedMarkup
  File "/home/vagrant/venv/lib/python3.4/site-packages/bs4/builder/__init__.py", line 314, in <module>
    from . import _html5lib
  File "/home/vagrant/venv/lib/python3.4/site-packages/bs4/builder/_html5lib.py", line 70, in <module>
    class TreeBuilderForHtml5lib(html5lib.treebuilders._base.TreeBuilder):
AttributeError: 'module' object has no attribute '_base'

@timorieber
Copy link
Contributor

Fixes #2843

@kaedroho kaedroho merged commit f0e8a5f into wagtail:stable/1.5.x Jul 15, 2016
@kaedroho
Copy link
Contributor

Thanks @SableWalnut I've also merged this into master at: 4d77589

The test failures appear to be unrelated, I'll look into those in the upstream branches now.

@m1kola
Copy link
Contributor

m1kola commented Jul 15, 2016

@kaedroho probably we also need to update 1.4, because it's LTS release.

@kaedroho
Copy link
Contributor

@m1kola yep, will do that now. Thanks!

@kaedroho
Copy link
Contributor

Merged into stable/1.4.x in 8290389

gasman added a commit to wagtail-deprecated/wagtaildemo that referenced this pull request Jul 18, 2016
The new version has breaking internal changes - see wagtail/wagtail#2842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants