Link generation is done by HtmlHelper::link() added escape and escapeTit... #17
Conversation
|
Thanks for the pull request but the test is failing. |
|
Fixed |
|
Awesome 👍 , but do we need both |
|
The title was duplicated on |
|
Do you need anything else? |
|
@redd No, I just wanted to have a look at it. But, Sorry I was very busy. |
| @@ -1102,7 +1102,7 @@ public function testImageMenu() { | |||
| '</li', | |||
| '<li', | |||
| array('a' => array('title' => 'Item 2', 'href' => '/item-2')), | |||
| array('img' => array('src' => '/path/my-image.jpg', 'alt' => 'Item 2', 'title' => 'Item 2')), | |||
There was a problem hiding this comment.
@redd I was little bit concerned about this one. This means the change will break the current versions. Right?
There was a problem hiding this comment.
Yes, but title is reduntant when you've alt on image and title on the link.
There was a problem hiding this comment.
Yes, I agree with you that it is redundant. But, before pushing this change I have to add a how to upgrade section. Or, many existing users will end up having a broken site.
There was a problem hiding this comment.
I think that (eventually) don't showing title is a little abuse to have broken sites :) But when image is in the link it should without problems show link's title.
Link generation is done by HtmlHelper::link() added escape and escapeTit...
...le options.