Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoreload doesn't work on windows #319

Closed
bdarnell opened this issue Jul 28, 2011 · 1 comment
Closed

autoreload doesn't work on windows #319

bdarnell opened this issue Jul 28, 2011 · 1 comment

Comments

@bdarnell
Copy link
Member

os.execv on windows is broken on windows when arguments contain spaces, and now it can't be fixed for fear of breaking workarounds people have built on top of it: http://bugs.python.org/issue436259

It looks like subprocess does the right thing here, so autoreload should probably just use subprocess (and then exit from the parent process) on platforms that don't have a working unix-style os.execv.

@mmalecki
Copy link

@bdarnell
This seems to be a fix. Autoreload didn't work for me on Windows, because I have a white space in path to my executable.
It's also a bit tricky to test, but I will try to, if needed.
Review, please (or should I pull request?).

bdarnell pushed a commit that referenced this issue Aug 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants