Add wildcard support to %include on configuration files (ticket 25140) #489

Jigsaw52 · 2018-11-07T20:15:22Z

No description provided.

coveralls · 2018-11-08T00:26:54Z

Pull Request Test Coverage Report for Build 6152

141 of 158 (89.24%) changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.06%) to 63.235%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/app/config/config.c	1	2	50.0%
src/lib/fs/conffile.c	47	49	95.92%
src/lib/fs/path.c	87	101	86.14%

Files with Coverage Reduction	New Missed Lines	%
src/lib/sandbox/sandbox.c	1	1.6%

Totals
Change from base Build 6120:	0.06%
Covered Lines:	47908
Relevant Lines:	75762

💛 - Coveralls

ahf

Minor details that needs to be fixed. Good stuff in general.

doc/tor.1.txt

src/config/torrc.sample.in

src/lib/fs/path.c

Jigsaw52 · 2018-12-12T17:22:24Z

I've fixed the mentioned issues. Additionally, I've rebased to the current master and added support for bool type on the checkSpace.pl script because it started complaining when I had functions returning bool.

ahf

Minor detail

changes/feature25140

src/config/torrc.sample.in

doc/tor.1.txt

src/lib/fs/conffile.c

src/lib/fs/path.c

src/lib/fs/path.h

doc/tor.1.txt

src/test/test_util.c

tor_glob returns a list of paths matching the specified pattern

Adds support for wildcards on path components before last

Also fixes some diffrent wildcard behaviour between Windows and Linux

Adds test for get_glob_opened_files and improves tor_glob and config tests

glob uses lstat which was not allowed by the seccomp filters

Reverting because it is a duplicate of the work done for #25140 This reverts commit ba3c785.

Co-Authored-By: Jigsaw52 <Jigsaw52@users.noreply.github.com>

Adds is_file and is_dir to files.h and some other minor improvements

Adds documentation about using %include and Sandbox, expansion of dot files in wildcards and Windows wildcard quirks.

Convert duplicated code on both functions to common small auxiliary functions.

Tests wildcards in %include, reloading the config file and response of SAVECONF and getinfo config-can-saveconf control commands.

Fixes reloading torrc with seccomp sandbox enabled on machines with libc version < 2.26. Although libc before the 2.26 version did not used openat for opening files, it used it on readdir. The seccomp %include rules were update to allow openat on any %included directories. This caused the %include integration test to fail when the seccomp sandbox was enabled.

Adds seccomp rules for socket and getpeername used by NSS

Jigsaw52 · 2020-06-03T21:22:08Z

Closed because new pull request #1915 with new implementation was made.

Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebased branch from dee5c2e to 517a3f2 Compare November 8, 2018 00:04

Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebased branch 2 times, most recently from 63a929f to 2314057 Compare November 8, 2018 16:32

ahf requested changes Dec 10, 2018

View reviewed changes

Jigsaw52 force-pushed the torrc-include-wildcards-25140_rebased branch 2 times, most recently from 56465f6 to 49e8156 Compare December 12, 2018 14:33

ahf approved these changes Jan 11, 2019

View reviewed changes

changes/feature25140 Outdated Show resolved Hide resolved