Update panic.c #684

palmarci · 2019-06-02T21:39:34Z

No description provided.

KernelPRBot · 2019-06-02T21:40:13Z

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

Format your contribution according to kernel requirements
Decide who to send your contribution to
Set up your system to send your contribution as an email
Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Who do I send my contribution to?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

Kernel Newbies - this website contains a lot of useful resources for new kernel developers.
The kernel documentation - see also the Documentation directory in the kernel tree.

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
- Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
- Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
- Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Working with the kernel development community - the official documentation for new kernel contributors

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

nipolascage · 2019-06-02T22:50:06Z

bruh

Deauthorized · 2019-06-03T00:33:35Z

bwuh

MartinX3 · 2019-06-03T09:03:16Z

Bruh!

MWGuy · 2019-06-03T09:28:28Z

Брух!

jackmerrill · 2019-06-03T20:25:34Z

b r u h
r
u
h

alyosharomanov · 2019-06-03T22:37:23Z

Certified bruh moment

s5bug · 2019-06-04T16:06:58Z

Bruh Sound Effect #2.mp3

murray-elijah · 2019-06-04T16:11:22Z

from bruh import moment

ZachyCatGames · 2019-06-04T16:14:59Z

bruh moment

andraantariksa · 2019-06-04T16:19:05Z

Bwuh mowment UwU

BlaiseSaunders · 2019-06-04T16:19:22Z

bruh

prateekj117 · 2019-06-04T16:19:41Z

bruh

alyosharomanov

This is correct

rafaelwastaken · 2019-06-04T16:31:04Z

MartinX3

This raises the bruh moment on end user brains!

skittlemittle

most impressive

drozdziak1 · 2019-06-05T09:43:27Z

kernel/panic.c

@@ -210,7 +210,7 @@ void panic(const char *fmt, ...)
 	if (len && buf[len - 1] == '\n')
 		buf[len - 1] = '\0';

-	pr_emerg("Kernel panic - not syncing: %s\n", buf);
+	pr_emerg("Bruh moment - not syncing: %s\n", buf);


certified bruh moment

🅱🆁🆄🅷

🅱🆁🆄🅷

𝕓𝕣𝕦𝕙

b̾r̾u̾h̾

native-m · 2019-06-05T12:00:00Z

bruhhhhh

ghost

#MergeIt

[ Upstream commit 524bb1d ] The function device_pm_check_callbacks() can be called under the spin lock (in the reported case it happens from genpd_add_device() -> dev_pm_domain_set(), when the genpd uses spinlocks rather than mutexes. However this function uncoditionally uses spin_lock_irq() / spin_unlock_irq(), thus not preserving the CPU flags. Use the irqsave/irqrestore instead. The backtrace for the reference: [ 2.752010] ------------[ cut here ]------------ [ 2.756769] raw_local_irq_restore() called with IRQs enabled [ 2.762596] WARNING: CPU: 4 PID: 1 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x34/0x50 [ 2.772338] Modules linked in: [ 2.775487] CPU: 4 PID: 1 Comm: swapper/0 Tainted: G S 5.17.0-rc6-00384-ge330d0d82eff-dirty torvalds#684 [ 2.781384] Freeing initrd memory: 46024K [ 2.785839] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.785841] pc : warn_bogus_irq_restore+0x34/0x50 [ 2.785844] lr : warn_bogus_irq_restore+0x34/0x50 [ 2.785846] sp : ffff80000805b7d0 [ 2.785847] x29: ffff80000805b7d0 x28: 0000000000000000 x27: 0000000000000002 [ 2.785850] x26: ffffd40e80930b18 x25: ffff7ee2329192b8 x24: ffff7edfc9f60800 [ 2.785853] x23: ffffd40e80930b18 x22: ffffd40e80930d30 x21: ffff7edfc0dffa00 [ 2.785856] x20: ffff7edfc09e3768 x19: 0000000000000000 x18: ffffffffffffffff [ 2.845775] x17: 6572206f74206465 x16: 6c696166203a3030 x15: ffff80008805b4f7 [ 2.853108] x14: 0000000000000000 x13: ffffd40e809550b0 x12: 00000000000003d8 [ 2.860441] x11: 0000000000000148 x10: ffffd40e809550b0 x9 : ffffd40e809550b0 [ 2.867774] x8 : 00000000ffffefff x7 : ffffd40e809ad0b0 x6 : ffffd40e809ad0b0 [ 2.875107] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.882440] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff7edfc03a8000 [ 2.889774] Call trace: [ 2.892290] warn_bogus_irq_restore+0x34/0x50 [ 2.896770] _raw_spin_unlock_irqrestore+0x94/0xa0 [ 2.901690] genpd_unlock_spin+0x20/0x30 [ 2.905724] genpd_add_device+0x100/0x2d0 [ 2.909850] __genpd_dev_pm_attach+0xa8/0x23c [ 2.914329] genpd_dev_pm_attach_by_id+0xc4/0x190 [ 2.919167] genpd_dev_pm_attach_by_name+0x3c/0xd0 [ 2.924086] dev_pm_domain_attach_by_name+0x24/0x30 [ 2.929102] psci_dt_attach_cpu+0x24/0x90 [ 2.933230] psci_cpuidle_probe+0x2d4/0x46c [ 2.937534] platform_probe+0x68/0xe0 [ 2.941304] really_probe.part.0+0x9c/0x2fc [ 2.945605] __driver_probe_device+0x98/0x144 [ 2.950085] driver_probe_device+0x44/0x15c [ 2.954385] __device_attach_driver+0xb8/0x120 [ 2.958950] bus_for_each_drv+0x78/0xd0 [ 2.962896] __device_attach+0xd8/0x180 [ 2.966843] device_initial_probe+0x14/0x20 [ 2.971144] bus_probe_device+0x9c/0xa4 [ 2.975092] device_add+0x380/0x88c [ 2.978679] platform_device_add+0x114/0x234 [ 2.983067] platform_device_register_full+0x100/0x190 [ 2.988344] psci_idle_init+0x6c/0xb0 [ 2.992113] do_one_initcall+0x74/0x3a0 [ 2.996060] kernel_init_freeable+0x2fc/0x384 [ 3.000543] kernel_init+0x28/0x130 [ 3.004132] ret_from_fork+0x10/0x20 [ 3.007817] irq event stamp: 319826 [ 3.011404] hardirqs last enabled at (319825): [<ffffd40e7eda0268>] __up_console_sem+0x78/0x84 [ 3.020332] hardirqs last disabled at (319826): [<ffffd40e7fd6d9d8>] el1_dbg+0x24/0x8c [ 3.028458] softirqs last enabled at (318312): [<ffffd40e7ec90410>] _stext+0x410/0x588 [ 3.036678] softirqs last disabled at (318299): [<ffffd40e7ed1bf68>] __irq_exit_rcu+0x158/0x174 [ 3.045607] ---[ end trace 0000000000000000 ]--- Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>

Update panic.c

402f0ff

alyosharomanov approved these changes Jun 4, 2019

View reviewed changes

matmen approved these changes Jun 4, 2019

View reviewed changes

MartinX3 approved these changes Jun 4, 2019

View reviewed changes

rxdn approved these changes Jun 4, 2019

View reviewed changes

nipolascage approved these changes Jun 4, 2019

View reviewed changes

azjezz approved these changes Jun 4, 2019

View reviewed changes

kylemay-gridstone approved these changes Jun 5, 2019

View reviewed changes

ConnorMcF approved these changes Jun 5, 2019

View reviewed changes

rafaelwastaken approved these changes Jun 5, 2019

View reviewed changes

skittlemittle approved these changes Jun 5, 2019

View reviewed changes

drozdziak1 approved these changes Jun 5, 2019

View reviewed changes

sam6321 approved these changes Jun 5, 2019

View reviewed changes

jsmirandaiii approved these changes Jun 5, 2019

View reviewed changes

ghost approved these changes Jun 5, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update panic.c #684

Update panic.c #684

palmarci commented Jun 2, 2019

KernelPRBot commented Jun 2, 2019

nipolascage commented Jun 2, 2019

Deauthorized commented Jun 3, 2019 •

edited

MartinX3 commented Jun 3, 2019

MWGuy commented Jun 3, 2019

jackmerrill commented Jun 3, 2019

alyosharomanov commented Jun 3, 2019

s5bug commented Jun 4, 2019

murray-elijah commented Jun 4, 2019 •

edited

ZachyCatGames commented Jun 4, 2019

andraantariksa commented Jun 4, 2019

BlaiseSaunders commented Jun 4, 2019

prateekj117 commented Jun 4, 2019

alyosharomanov left a comment

rafaelwastaken commented Jun 4, 2019

MartinX3 left a comment

skittlemittle left a comment

drozdziak1 Jun 5, 2019

sam6321 Jun 5, 2019

idiosyncrati Jun 5, 2019

Francesco149 Jun 5, 2019

MarioTalevski Jun 5, 2019

willfenton Nov 21, 2019

Veetaha Nov 23, 2019

christopherhui Dec 8, 2019

StaticallyTypedRice Feb 19, 2020

0x1 Feb 20, 2020

native-m commented Jun 5, 2019

ghost left a comment

Update panic.c #684

Are you sure you want to change the base?

Update panic.c #684

Conversation

palmarci commented Jun 2, 2019

KernelPRBot commented Jun 2, 2019

How do I format my contribution?

Who do I send my contribution to?

How do I send my contribution?

How do I get help if I'm stuck?

I sent my patch - now what?

Further information

nipolascage commented Jun 2, 2019

Deauthorized commented Jun 3, 2019 • edited

MartinX3 commented Jun 3, 2019

MWGuy commented Jun 3, 2019

jackmerrill commented Jun 3, 2019

alyosharomanov commented Jun 3, 2019

s5bug commented Jun 4, 2019

murray-elijah commented Jun 4, 2019 • edited

ZachyCatGames commented Jun 4, 2019

andraantariksa commented Jun 4, 2019

BlaiseSaunders commented Jun 4, 2019

prateekj117 commented Jun 4, 2019

alyosharomanov left a comment

Choose a reason for hiding this comment

rafaelwastaken commented Jun 4, 2019

MartinX3 left a comment

Choose a reason for hiding this comment

skittlemittle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

𝕓𝕣𝕦𝕙

Choose a reason for hiding this comment

native-m commented Jun 5, 2019

ghost left a comment

Choose a reason for hiding this comment

Deauthorized commented Jun 3, 2019 •

edited

murray-elijah commented Jun 4, 2019 •

edited