MatchValidator broken due to CompoundWidget state #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a test unit to expose that MatchValidator stopped working due to change in CompoundWidget now correctly passing a state when validating (this is required for compatibility on i18n with FormEncode). The proposed fix provides the values of the CompoundWidget inside the state when it gets validated. The values are available inside full_dict for coherence with FormEncode and states are copied before updating them to provide a stack of states instead of replacing the original one.
|
Can I merge this myself? is everyone fine with the change? |
|
👍 :) |
amol-
added a commit
that referenced
this pull request
Feb 17, 2014
MatchValidator broken due to CompoundWidget state
|
Would it be possible to make a release with this fix? The MatchValidator is broken without it. |
moschlar
added a commit
to toscawidgets/tw2.forms
that referenced
this pull request
Jul 25, 2014
|
Hey @amol- , could you have a look at the (newly added) broken test case that fails because of this change? File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/widgets.py", line 523, in validate
return ins._validate(value, state)
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/forms/widgets.py", line 744, in _validate
StripBlanks().to_python(value, state), state
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/validation.py", line 106, in wrapper
d = fn(self, *args, **kw)
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/widgets.py", line 871, in _validate
data.append(self.children[i]._validate(v, data))
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/validation.py", line 106, in wrapper
d = fn(self, *args, **kw)
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/widgets.py", line 669, in _validate
state = util.clone_object(state, full_dict=value, validated_values=data)
File "/home/moschlar/.virtualenvs/tw2/lib/python2.7/site-packages/tw2/core/util.py", line 139, in clone_object
setattr(obj, k, v)
AttributeError: 'list' object has no attribute 'validated_values'Encountered this while trying things for toscawidgets/tw2.forms#38 |
|
16edf65 should fix issue with wrong state. But the test is still failing as it expects a different result. Is it meant that the test expects As we are validating |
|
Ah, well, no... Thanks for the fix! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a test unit to expose that MatchValidator stopped working due to change in CompoundWidget now correctly passing a state when validating (this is required for compatibility on i18n with FormEncode). The proposed fix provides the values of the CompoundWidget inside the state when it gets validated. The values are available inside full_dict for coherence with FormEncode and states are copied before updating them to provide a stack of states instead of replacing the original one.