Add jinja2 widget templates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al case html boolean attributes such as radio 'checked', jinja templates now passes all tests.
|
Really nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added full jinja2 templates to widgets.
Genshi can transform a dict into an appropiate string of html attributes, mako emulates this with an extension (mako_util), jinja has a filter that does something similar xmlattr, however this filter does not handle special cases such as checked or selected attributes where the input dictionary has a value of True but the correct html attribute should read checked="checked".
To solve the mentioned issue and to get 100% tests passing this needs a patch to tw2.core which adds a small filter called htmlbools which checks this special cases and accomodates the correct values. This patch has been submited as a pull request to tw2.core (toscawidgets/tw2.core#48).