Added improved typings for Array.every #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This should do it, as far as I can tell there are no further regressions in the codebases I've tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improved typings to
Array.everywhen using theBooleanconstructor, in a way that's very similar to what's already being done forArray.filter.After extensive testing, these types seem to always behave as expected, narrowing the type of the array or tuple down as much as possible (possibly even to
never).I haven't added this feature to
recommended.d.tsbecause I'd like to have some feedback on this first, but I feel like it would make sense to add it there since this is very much in line with theArray.filterimprovements, which are recommended.