Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carol Init #26

Closed
rafonseca opened this issue Aug 22, 2018 · 1 comment
Closed

Carol Init #26

rafonseca opened this issue Aug 22, 2018 · 1 comment

Comments

@rafonseca
Copy link
Contributor

rafonseca commented Aug 22, 2018

Carol init is like this

 login = Carol(os.environ['CAROLTENANT'],
               APP_NAME,
               auth=ApiKeyAuth(os.environ['CAROLAPPOAUTH']),
               connector_id=os.environ['CAROLCONNECTORID'])

This is wrong.. Not a matter of taste. It should be like this

 login = Carol(os.environ['CAROLTENANT'],
               APP_NAME,
               auth=os.environ['CAROLAPPOAUTH'],
               connector_id=os.environ['CAROLCONNECTORID'])

If possible, we should drop APP_NAME

 login = Carol(os.environ['CAROLTENANT'],
               auth=os.environ['CAROLAPPOAUTH'],
               connector_id=os.environ['CAROLCONNECTORID'])

Still better, if it were like this

 login = Carol(os.environ['CAROLTENANT'],
               X-Auth-Key=os.environ['CAROLAPPOAUTH'],
               X-Auth-ConnectorId=os.environ['CAROLCONNECTORID'])

easy to fix, but I can't create a branch here

@wmsouza
Copy link
Contributor

wmsouza commented Sep 19, 2018

This should be solved with the changes on 2.0-init, as from now on we will just call Carol() with no parameters as the standard (we still can send the parameters if needed), and it will automatically read from the app.settings or the environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants