-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't call NativeCompilerDownloader in SKIE 0.8.0 #83
Comments
Hey @chrisbanes, thanks for the report. Can you check if you by any change have In the meantime I'll try to reproduce it in our tests. We actually don't use reflection to call these APIs (unless we missed something), but we did have to change how we call them to get SKIE working with Gradle Configuration Cache. |
We don't have |
That seems like SKIE can't automatically determine your Kotlin Gradle plugin version. Could you check if perhaps you have an old Kotlin version left somewhere that happened during upgrading? |
Everything is controlled via I'll try with |
So it should actually error out if it can't find the version. In this case it seems like it's finding a wrong version, which shouldn't happen. The reason why it's |
@chrisbanes Do you use |
Yes, exactly
We add a Our KMP convention plugin calls |
Thanks, that's good info. And for the |
It's all defined in a [versions]
kotlin = "2.0.0"
[plugins]
kotlin-multiplatform = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin" }
[libraries]
kotlin-gradlePlugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" } |
Thanks, I'll try to reproduce it and possibly ask more questions if I can't. |
No luck so far. What version of Gradle are you using? And could you share more about how you apply SKIE Gradle plugin? And could you share the message SKIE prints when running with |
Hi! We added some additional debug logging in 0.8.1. Can you please try this version with |
Here's the log. It seems to be finding Kotlin 1.9.22 from the classpath, but I have no idea how it's finding that. |
Try running the |
I'm seeing a lot of: Is this a timing issue? Is SKIE checking the classpath before Ivy has fully resolved the dependencies? |
I don't think it can be a timing issue (doesn't necessarily mean it isn't :D). SKIE looks for the |
I don't see |
Oh, sorry I gave you a wrong task. The correct one should be |
Ah thanks! Found the issue.
|
Funny that it's caused by one of our libraries :D It should have However, it's also a bug in the SKIE version resolution because the KGP version used by your Gradle script is different in the end. I'll try to reproduce the issue locally. |
Fixed in 0.8.2. |
I see that SKIE 0.8.0 is now using reflection to call KGP APIs, but it seems that this is completely breaking our usage.
What is the problem?
When does the problem occur?
Any Gradle task
How do we reproduce the issue?
Honestly, I don't really know. We use some convention plugins to apply a bunch of KGP, CMP and Skie settings. I've tried clearing out the entire Gradle cache, turning off configuration cache, etc.
What has changed since the last time SKIE worked in your project?
Updating to Kotlin 2.0.0 and SKIE 0.8.0
The text was updated successfully, but these errors were encountered: