Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unscorable allowPast is dumb #20

Closed
clux opened this issue Oct 2, 2014 · 1 comment
Closed

unscorable allowPast is dumb #20

clux opened this issue Oct 2, 2014 · 1 comment

Comments

@clux
Copy link
Collaborator

clux commented Oct 2, 2014

Just mis-scored the match? Now it's considered past. It won't affect anything to rescore it, but there is no difference between this case and an actually dangerous recore.

Implement a default "virtual" that implementations can override with a check if the current match has something in its progression tree (and so is unsafe to rescore). Duel could simply check if right or down is played, ffa could check if next round has any played matches (although this is not a problem in upcoming ffa-tb), groupstage could just return false or have an option for it.

@clux
Copy link
Collaborator Author

clux commented Oct 2, 2014

Fixed in duel and ffa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant