New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewService's error is hardcoded to io::Error #4

Closed

carllerche opened this issue Jul 30, 2017 · 2 comments

Member

carllerche commented Jul 30, 2017

https://github.com/carllerche/tower/blob/d5f253c577a98210f4bda336677da95dd91142b0/src/lib.rs#L176

I'm not sure what the original reasoning was, probably to have less generics. That said, it would probably be worth revisiting.

carllerche mentioned this issue

NewService returns a Future. #1

Merged

Member Author

carllerche commented Jul 30, 2017

Existing discussion is here: https://github.com/carllerche/tower/pull/1/files/43d09077692370a461f154d0d337d35d60b9dc52#diff-b4aea3e418ccdb71239b96952d9cddb6

Member Author

carllerche commented Oct 3, 2017

This is fixed by #5

carllerche closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment