Release build of tower / tide failes

[Roba1993]

Hi my release builds are failing since the version tower v0.4.9
This is the error message:

error[E0710]: an unknown tool name found in scoped lint: `rustdoc::broken_intra_doc_links`
 --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tower-0.4.9/src/lib.rs:8:9
  |
8 | #![deny(rustdoc::broken_intra_doc_links)]
  |         ^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0710`.
error: could not compile `tower`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Was a release build testet for the new version?

[davidpdrsn]

We changed the lint without realizing it wouldn't work on older versions of rust. Are you able to update to the latest rust version?

I would be fine with doing another release that fixes it seeing as this is a breaking change. Wdyt @LucioFranco @hawkw?

CI should probably also have caught this 🤔

[hawkw]

We changed the lint without realizing it wouldn't work on older versions of rust. Are you able to update to the latest rust version?

I would be fine with doing another release that fixes it seeing as this is a breaking change. Wdyt @LucioFranco @hawkw?

Yeah, we should probably change the attribute to #![cfg_attr(docsrs, deny(rustdoc::broken_intra_doc_links)] so that it's only set when building the docs on nightly. We should probably also yank v0.4.9 to avoid breaking people's MSRV builds?

[hawkw]

I'm also somewhat concerned that the CI MSRV build didn't catch this? It looks like it should have:

tower/.github/workflows/CI.yml

Lines 22 to 26 in 62e0902

	- name: Check
	uses: actions-rs/cargo@v1
	with:
	command: check
	args: --all --all-targets --all-features

[Roba1993]

@davidpdrsn I switched to the newest rust version and it works with that. So I'm good, but still I think it should be fixed.

[davidpdrsn]

I agree. I'll release a new version next week.