Allow the user to set a container as privileged
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcrosta Is this something you'd be happy to merge? |
|
Can you say more about the use case here? I'm trying to understand how widespread this is, and whether there are any workarounds |
https://github.com/judahrand/sherlock/blob/83c3817690c487b181c3f2eddcc3752f61be7630/tox.ini#L46-L61 I'm using an image to perform integration testing using Kubernetes. This requires privilege. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to set up some integration tests which need
k3sto run. However, this container needs to run asprivileged.This deals with this better than #131 as it handles the possible string values passed in the
.inifile.