Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Register {temp_dir} as a valid substitution #1609

Merged
merged 2 commits into from Jun 29, 2020

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Jun 28, 2020

This change recovers a missing temp_dir substitution.
The docs for it were added in #1032 but it never actually worked.

Fixes #1608

Contribution checklist:

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

This change recovers a missing `temp_dir` substitution.
The docs for it were added in tox-dev#1032 but it never actually worked.

Fixes tox-dev#1608
webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 28, 2020
webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 28, 2020
Copy link
Member

@gaborbernat gaborbernat left a comment

.

@gaborbernat gaborbernat merged commit 1b4c4e5 into tox-dev:master Jun 29, 2020
25 checks passed
@webknjaz
Copy link
Contributor Author

webknjaz commented Jun 29, 2020

@gaborbernat thanks! mind publishing a bugfix release?

@gaborbernat
Copy link
Member

gaborbernat commented Jun 29, 2020

@webknjaz #1610

webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 29, 2020
This change enxures that `{temp_dir}` substitution actually works.

Refs:
* tox-dev/tox#1608
* tox-dev/tox#1609
* tox-dev/tox#1610
ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
webknjaz added a commit to webknjaz/ansible-navigator that referenced this issue Aug 21, 2021
webknjaz added a commit to webknjaz/ansible-navigator that referenced this issue Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants