Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable config.h in MSVC #15

Closed
QbProg opened this issue May 25, 2011 · 6 comments · Fixed by #65
Closed

Enable config.h in MSVC #15

QbProg opened this issue May 25, 2011 · 6 comments · Fixed by #65
Milestone

Comments

@QbProg
Copy link
Collaborator

QbProg commented May 25, 2011

At least some compilation/install options saved in config.h could be useful at compilation time (eg data directory names)
This will allow a more uniform behavoir between systems.

@dbarbier
Copy link
Collaborator

Did you try to add -DHAVE_CONFIG_H to compilation flags? If everything works fine, we can add this flag on Win32 too.

@dbarbier
Copy link
Collaborator

ping? I would like to remove #ifdef HAVE_CONFIG_H from inc/*.hxx files (but not src/, this is unnecessary) to let them unconditionnally include oce-config.h, it is extremely annoying to still have to set -DHAVE_CONFIG_H when compiling a program using OCE.

@QbProg
Copy link
Collaborator Author

QbProg commented Jul 29, 2011

I'll try this this evening !

2011/7/29 dbarbier
reply@reply.github.com:

ping?  I would like to remove #ifdef HAVE_CONFIG_H from inc/*.hxx files (but not src/, this is unnecessary) to let them unconditionnally include oce-config.h, it is extremely annoying to still have to set -DHAVE_CONFIG_H when compiling a program using OCE.

Reply to this email directly or view it on GitHub:
#15 (comment)

@dbarbier
Copy link
Collaborator

Please test review/unconditionnaly-include-config-file branch.

@QbProg
Copy link
Collaborator Author

QbProg commented Jul 29, 2011

it builds on MSVC.

There are still some things to do before closing the bug:

  • not all defines are really defined
  • no define is defined in the "installed" config.h
  • there are still HAVE_CONFIG_H checks in the cpp files
  • the FULL installation path is taken in the OCE_CONFIG.h : this is not really good in windows since the binaries must be allowed to be installed on different paths
    (this is used here and there to define casroot).
    This last point is releated to OCE does not follow standard installation paths #2

@dbarbier
Copy link
Collaborator

I am closing this issue, changes have been committed recently. I guess that there are still issues, but it is better to file specific bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants