Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use other time objects than \DateTime #51

Closed
burzum opened this issue Feb 28, 2016 · 1 comment
Closed

Make it possible to use other time objects than \DateTime #51

burzum opened this issue Feb 28, 2016 · 1 comment

Comments

@burzum
Copy link

burzum commented Feb 28, 2016

The lib has hard dependencies on a few base classes:

$this->until(new \DateTime($param));
$this->until->add(new \DateInterval('P400Y'));

It should be possible to change them. Either by providing a method than can be overloaded or a getter and setter that will allow me to define the interval and date objects.

Calling the classes directly in the code makes it impossible to work with custom date objects.

@tplaner
Copy link
Owner

tplaner commented Aug 29, 2021

Good idea, will take this into consideration for a future rewrite.

@tplaner tplaner closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants