Reintroduce automatic derivation of Get and Put
#1350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types with magnolia (requires magnolia snapshot)
|
This is a concrete proposal now that doesn't change anything in magnolia anymore. I'd still wait a bit on feedback on the PR I opened there as this could still be better solved on that side I think. It's obviously not entirely optimal to define local macro in doobie, but it's only for scala 2, and it's not that complex I think. An alternative to this solution is to resurrect the shapeless dependency and use that only to infer |
jatcwang
reviewed
Jan 23, 2021
jatcwang
reviewed
Jan 25, 2021
|
|
||
| case class No1(i: Int, s: String) | ||
| object No2 | ||
| case class Y private (x: String) |
There was a problem hiding this comment.
This isn't used? (and it shouldn't be possible, since constructor is private)
|
I'm losing confidence that this is the way to go. For now I'm going to revert #1343 and maybe we can revisit if it's fixed in Magnolia. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #1343 .
I made a proposal in softwaremill/magnolia#278 , and this implements it on the doobie side.
I fully expect some discussion about what it'll look like in the end, just opening this in a draft state this to show that it might be easy to fix.