Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands relying on $VIM env var stop working properly when using dispatch #308

Open
foca opened this issue Dec 20, 2020 · 1 comment
Open

Comments

@foca
Copy link

foca commented Dec 20, 2020

Specifically, the minitest-reporters gem relies on $VIM being set to identify when running through vim to disable any fancy formatting and just outputting test results in a format that can be parsed back into the quicklist.

Since dispatch#isolate removes VIM, this then breaks, leading to garbled output. The quicklist then works, but looks ugly with color codes printed in between the output:

Screen Shot 2020-12-20 at 17 35 23

Could dispatch be made configurable to add a list of variables that can be kept while isolating? (or can it just be made available to the underlying process instead of stripping it from the env?)

@tpope
Copy link
Owner

tpope commented Mar 14, 2021

The reason we strip it out is so you can :Start a different version of Vim with everything going to hell. There isn't a reason to do that with :Dispatch, so I think that's the condition to operate on. I would expect this to be a simple change to dispatch#isolate to add a conditional based on a:request.action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants