-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Estimated completion date/time in bar_format
#1055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolayne
force-pushed
the
estimated_completion_datetime
branch
from
October 22, 2020 10:25
f3a2d6d
to
fe75e0a
Compare
Codecov Report
@@ Coverage Diff @@
## devel #1055 +/- ##
==========================================
+ Coverage 86.40% 86.44% +0.04%
==========================================
Files 22 22
Lines 1456 1461 +5
Branches 247 247
==========================================
+ Hits 1258 1263 +5
Misses 167 167
Partials 31 31 |
kolayne
force-pushed
the
estimated_completion_datetime
branch
from
October 22, 2020 10:42
fe75e0a
to
396262c
Compare
Exactly the implementation I was thinking of; thanks |
casperdcl
added
c1-quick 🕐
Complexity low
p3-enhancement 🔥
Much new such feature
question/docs ‽
Documentation clarification candidate
to-merge ↰
Imminent
labels
Oct 22, 2020
casperdcl
force-pushed
the
estimated_completion_datetime
branch
2 times, most recently
from
October 22, 2020 12:13
415c933
to
9cd652c
Compare
made a few changes
Example: tqdm(..., bar_format='{l_bar}{bar}| {n_fmt}/{total_fmt} [{rate_fmt} ETA:{eta:%y-%m-%d %H:%M}{postfix}]') |
would likely merge #1052 first before adding a test |
casperdcl
force-pushed
the
estimated_completion_datetime
branch
from
October 22, 2020 12:24
9cd652c
to
6f90e77
Compare
casperdcl
approved these changes
Oct 22, 2020
casperdcl
force-pushed
the
estimated_completion_datetime
branch
from
October 24, 2020 23:21
6f90e77
to
5ae54a3
Compare
casperdcl
force-pushed
the
estimated_completion_datetime
branch
from
October 24, 2020 23:30
5ae54a3
to
873e1bc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c1-quick 🕐
Complexity low
p3-enhancement 🔥
Much new such feature
question/docs ‽
Documentation clarification candidate
to-merge ↰
Imminent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1051
Adds the possibility to display ETA date and time. Example of basic usage of the feature:
How this looks
You can also customize the date format with the directives from the
datetime
library (see the official documentation):How this looks
Notes
randint
infloat
, but no changes totqdm
calls are needed)total
and length of an iterable is unavailable),eta_dt
defaults to the epoch beginning datetime (to not break formatting directives usage)