🎨 remove NewOAuthAPI function, remove HTTPClient field's assignment #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
グローバル変数じゃなくして
という点から全て |
|
|
ras0q
reviewed
Aug 26, 2024
infra/traq/group.go
Outdated
| ctx := context.TODO() | ||
| apiClient := NewOauth2APIClient(ctx, token) | ||
| ctx := context.WithValue(context.TODO(), traq.ContextAccessToken, token.AccessToken) | ||
| apiClient := traq.NewAPIClient(traqAPIConfig) |
There was a problem hiding this comment.
なるほどこれでいいのか
動くならこれでいい気もします
configはグローバルなものを使わずに毎回NewConfiguration()するのがよさそうです
|
手元環境で動かすとログインを試みたときに |
|
サーバーのアクセストークンを設定し忘れてたりしませんか? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPClientフィールドを書き換える処理が原因で不具合が起きていることが確認できたのでHTTPClientフィールドを書き換えないような処理に変更しました．