Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to perform memory fill by "bytes" #84

Closed
cycwll opened this issue Oct 7, 2023 · 1 comment
Closed

Bug: Unable to perform memory fill by "bytes" #84

cycwll opened this issue Oct 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cycwll
Copy link
Contributor

cycwll commented Oct 7, 2023

pod-->mem --> fill
Due to the limitations on the front end of the page, percentage is required and must be between 1 and 100, and cannot be 0. And once percent= 0, the number of injected bytes will be calculated based on percentage (source code chaosmetad pkg/utils/memory/mem. go). This results in the inability to specify a fixed byte value。

由于页面前端限制了 percent 为必填项,并且必须为1-100之间,不能为0。一旦 percent !=0 ,就会按percent计算注入的bytes数,(源码chaosmetad pkg/utils/memory/mem.go 34行)。从而导致无法指定一个固定的 bytes 值,或者说指定了也无效,因为percent不能填0。

image

另外,我个人觉得对于pod来说,这里的 percent 没什么实际意义,因为percent是按宿主机的内存指标计算的,与pod的request和limit都没有关系。这里的逻辑是否应该完善一下?不知道我的理解是否正确,还是这个设计是针对某特定场景而考虑的。

@KingsonKai KingsonKai added the bug Something isn't working label Oct 9, 2023
@KingsonKai
Copy link
Member

fix in v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants